Skip to content

build: update to latest version of rules_sass #23491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions WORKSPACE
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,10 @@ http_archive(
# Add sass rules
http_archive(
name = "io_bazel_rules_sass",
sha256 = "80d3e70ab5a8d59494aa9e3a7e4722f9f9a6fe98d1497be6bfa0b9e106b1ea54",
strip_prefix = "rules_sass-1.34.1",
sha256 = "60fa023fe694848acf769d816ad9fee970a27a37489aaf5443a7ccffaac805e9",
strip_prefix = "rules_sass-1.38.2",
urls = [
"https://github.com/bazelbuild/rules_sass/archive/1.34.1.zip",
"https://mirror.bazel.build/github.com/bazelbuild/rules_sass/archive/1.34.1.zip",
"https://github.com/bazelbuild/rules_sass/archive/1.38.2.zip",
],
)

Expand Down
3 changes: 1 addition & 2 deletions src/dev-app/mdc-select/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
load("@io_bazel_rules_sass//:defs.bzl", "sass_binary")
load("//tools:defaults.bzl", "ng_module")
load("//tools:defaults.bzl", "ng_module", "sass_binary")

package(default_visibility = ["//visibility:public"])

Expand Down
3 changes: 1 addition & 2 deletions src/dev-app/mdc-sidenav/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
load("@io_bazel_rules_sass//:defs.bzl", "sass_binary")
load("//tools:defaults.bzl", "ng_module")
load("//tools:defaults.bzl", "ng_module", "sass_binary")

package(default_visibility = ["//visibility:public"])

Expand Down
3 changes: 1 addition & 2 deletions src/dev-app/mdc-snack-bar/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
load("@io_bazel_rules_sass//:defs.bzl", "sass_binary")
load("//tools:defaults.bzl", "ng_module")
load("//tools:defaults.bzl", "ng_module", "sass_binary")

package(default_visibility = ["//visibility:public"])

Expand Down
3 changes: 1 addition & 2 deletions src/dev-app/table-scroll-container/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
load("@io_bazel_rules_sass//:defs.bzl", "sass_binary")
load("//tools:defaults.bzl", "ng_module")
load("//tools:defaults.bzl", "ng_module", "sass_binary")

package(default_visibility = ["//visibility:public"])

Expand Down
3 changes: 1 addition & 2 deletions src/material-experimental/column-resize/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
load("@io_bazel_rules_sass//:defs.bzl", "sass_library")
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite")
load("//tools:defaults.bzl", "ng_module", "ng_test_library", "ng_web_test_suite", "sass_library")

package(default_visibility = ["//visibility:public"])

Expand Down
3 changes: 1 addition & 2 deletions src/material-experimental/mdc-helpers/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
load("//tools:defaults.bzl", "sass_library")
load("//tools:npm_sass_library.bzl", "npm_sass_library")
load("//tools:defaults.bzl", "npm_sass_library", "sass_library")

package(default_visibility = ["//visibility:public"])

Expand Down
5 changes: 4 additions & 1 deletion tools/defaults.bzl
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Re-export of Bazel rules with repository-wide defaults

load("@build_bazel_rules_nodejs//:index.bzl", _pkg_npm = "pkg_npm")
load("@io_bazel_rules_sass//:defs.bzl", _sass_binary = "sass_binary", _sass_library = "sass_library")
load("@io_bazel_rules_sass//:defs.bzl", _npm_sass_library = "npm_sass_library", _sass_binary = "sass_binary", _sass_library = "sass_library")
load("@npm//@angular/bazel:index.bzl", _ng_module = "ng_module", _ng_package = "ng_package")
load("@npm//@bazel/jasmine:index.bzl", _jasmine_node_test = "jasmine_node_test")
load("@npm//@bazel/concatjs:index.bzl", _karma_web_test = "karma_web_test", _karma_web_test_suite = "karma_web_test_suite")
Expand Down Expand Up @@ -54,6 +54,9 @@ def sass_binary(sourcemap = False, **kwargs):
def sass_library(**kwargs):
_sass_library(**kwargs)

def npm_sass_library(**kwargs):
_npm_sass_library(**kwargs)

def ts_library(tsconfig = None, deps = [], testonly = False, **kwargs):
# Add tslib because we use import helpers for all public packages.
local_deps = ["@npm//tslib"] + deps
Expand Down
50 changes: 0 additions & 50 deletions tools/npm_sass_library.bzl

This file was deleted.