Skip to content

refactor(material/paginator): refactor tests for paginator texts #23516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2021
Merged

refactor(material/paginator): refactor tests for paginator texts #23516

merged 1 commit into from
Sep 7, 2021

Conversation

dnlrbz
Copy link
Contributor

@dnlrbz dnlrbz commented Sep 2, 2021

Refactored tests of the Angular Material paginator component. Removed comments and instead extracted tested behaviours into separate test cases, to keep them simple and isolated.

@dnlrbz dnlrbz requested a review from andrewseguin as a code owner September 2, 2021 13:14
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 2, 2021
@dnlrbz dnlrbz requested a review from crisbeto as a code owner September 2, 2021 13:26
Refactored tests of the Angular Material `paginator` component. Removed comments and instead extracted tested behaviours into separate test cases, to keep them simple and isolated.
@dnlrbz dnlrbz requested a review from crisbeto September 3, 2021 07:25
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Sep 3, 2021
@zarend zarend merged commit 71937ce into angular:master Sep 7, 2021
zarend pushed a commit that referenced this pull request Sep 7, 2021
)

Refactored tests of the Angular Material `paginator` component. Removed comments and instead extracted tested behaviours into separate test cases, to keep them simple and isolated.

(cherry picked from commit 71937ce)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants