Skip to content

refactor(material/button): use static string for selector #23537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2021
Merged

refactor(material/button): use static string for selector #23537

merged 1 commit into from
Sep 7, 2021

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 6, 2021 •
edited
Loading

Uses a static string for the selector of the button harness since the join call we had previously was showing up in the docs.

For reference:
Button__Angular_Material_-_Google_Chrome_2021-09-06_17-42-42

@crisbeto
refactor(material/button): use static string for selector
a39782b 
Uses a static string for the selector of the button harness since the `join` call we had previouly was showing up in the docs.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Sep 6, 2021
@crisbeto crisbeto requested a review from devversion September 6, 2021 15:43
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 6, 2021
devversion
devversion approved these changes Sep 6, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ideally we would throw an error in the Dgeni generation in such cases, but I think the selectors are more readable this way anyway.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Sep 6, 2021
jelbourn
jelbourn approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zarend zarend merged commit c5e3710 into angular:master Sep 7, 2021
zarend pushed a commit that referenced this pull request Sep 7, 2021
@crisbeto @zarend
refactor(material/button): use static string for selector (#23537)
69f442a 
Uses a static string for the selector of the button harness since the `join` call we had previouly was showing up in the docs.

(cherry picked from commit c5e3710)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @devversion @zarend