Skip to content

fix(dev-app): add ariaLabel to bottom sheet demo #23601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2021
Merged

fix(dev-app): add ariaLabel to bottom sheet demo #23601

merged 1 commit into from
Sep 21, 2021

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Sep 17, 2021

No description provided.

@zarend zarend added Accessibility This issue is related to accessibility (a11y) merge safe area: material/bottom-sheet labels Sep 17, 2021
@zarend zarend requested a review from jelbourn September 17, 2021 22:43
@zarend zarend requested a review from crisbeto as a code owner September 17, 2021 22:43
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 17, 2021
jelbourn
jelbourn approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

@zarend you'll need to change the commit to one of the allowed scopes

crisbeto
crisbeto approved these changes Sep 18, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For the dev app I usually set the commit scope as build.

@zarend zarend added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 20, 2021
@wagnermaciel wagnermaciel merged commit aa70a34 into angular:master Sep 21, 2021
wagnermaciel pushed a commit that referenced this pull request Sep 21, 2021
@zarend @wagnermaciel
build: add ariaLabel to bottom sheet demo (#23601)
dc658be 
(cherry picked from commit aa70a34)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@crisbeto crisbeto crisbeto approved these changes

Assignees
No one assigned
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/bottom-sheet cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zarend @jelbourn @crisbeto @wagnermaciel