fix(mdc/expansion-panel): add bottom border to header in high contras… #23613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zarend
added
Accessibility
google-cla
bot
added
the
cla: yes
jelbourn
approved these changes
Sep 21, 2021
|
Oh, and also the commit scope should be |
crisbeto
reviewed
Sep 22, 2021
Add a border between the header and its content when in high contrast mode.
zarend
force-pushed
the
expansion-panel
branch
from
a1ad730 to
087d3e2
Compare
zarend
added
target: patch
amysorto
pushed a commit
that referenced
this pull request
Sep 27, 2021
) Add a border between the header and its content when in high contrast mode. (cherry picked from commit d13b8ea)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t mode
This works great when the content below the header had top padding, but looks like a mistake when there is no space between the content and the header. We could compensate for this by margin below the header, but maybe is should be up to the application developer to decide how to style this. There might be situations where we don't want any padding under the header, of we might add duplicate padding that results in too much padding.
This change only affects high-contrast mode. YDYT?
Screenshots
Before
After