refactor(material/schematics): do not print hammer migration message when updating to v13 #23752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
P3
google-cla
bot
added
the
cla: yes
devversion
commented
Oct 14, 2021
src/material/schematics/ng-update/migrations/hammer-gestures-v9/hammer-gestures-migration.ts
Show resolved
Hide resolved
crisbeto
reviewed
Oct 14, 2021
src/material/schematics/ng-update/migrations/hammer-gestures-v9/hammer-gestures-migration.ts
Outdated
Show resolved
Hide resolved
crisbeto
approved these changes
Oct 14, 2021
src/material/schematics/ng-update/migrations/hammer-gestures-v9/hammer-gestures-migration.ts
Outdated
Show resolved
Hide resolved
devversion
force-pushed
the
refactor/material-schematics
branch
from
2e2ae51 to
fbc07f6
Compare
devversion
added
action: merge
|
@devversion This needs a rebase |
…when updating to v13 The Hammer gesture migration runs only for v9 and v10 but the global post migration messages are printed regardless of whether the update runs for v9 or v10. This commit fixes that by providing the target version to the `globalPostMigration` functions for migrations.
devversion
force-pushed
the
refactor/material-schematics
branch
from
fbc07f6 to
65e7542
Compare
|
@wagnermaciel Done |
wagnermaciel
pushed a commit
that referenced
this pull request
Oct 21, 2021
…when updating to v13 (#23752) The Hammer gesture migration runs only for v9 and v10 but the global post migration messages are printed regardless of whether the update runs for v9 or v10. This commit fixes that by providing the target version to the `globalPostMigration` functions for migrations. (cherry picked from commit 44ba424)
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Oct 22, 2021
…when updating to v13 (angular#23752) The Hammer gesture migration runs only for v9 and v10 but the global post migration messages are printed regardless of whether the update runs for v9 or v10. This commit fixes that by providing the target version to the `globalPostMigration` functions for migrations.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hammer gesture migration runs only for v9 and v10 but the global
post migration messages are printed regardless of whether the update
runs for v9 or v10. This commit fixes that by providing the target
version to the
globalPostMigrationfunctions for migrations.