Skip to content

build: set up prettier in default editor config #23790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

build: set up prettier in default editor config #23790

merged 1 commit into from
Oct 21, 2021

Conversation

crisbeto
Copy link
Member

Updates the default editor settings to format on save and to recommend the Prettier extension.

@crisbeto
build: set up prettier in default editor config
b5fdcd7 
Updates the default editor settings to format on save and to recommend the Prettier extension.
@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: rc This PR is targeted for the next release-candidate labels Oct 20, 2021
@crisbeto crisbeto requested review from mmalerba and a team as code owners October 20, 2021 06:49
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 20, 2021
devversion
devversion approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I didn't know we had this configured.

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 20, 2021
@wagnermaciel wagnermaciel merged commit 283d44d into angular:master Oct 21, 2021
wagnermaciel pushed a commit that referenced this pull request Oct 21, 2021
@crisbeto @wagnermaciel
build: set up prettier in default editor config (#23790)
99d3379 
Updates the default editor settings to format on save and to recommend the Prettier extension.

(cherry picked from commit 283d44d)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Oct 22, 2021
@crisbeto @forsti0506
build: set up prettier in default editor config (angular#23790)
4316892 
Updates the default editor settings to format on save and to recommend the Prettier extension.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @devversion @wagnermaciel