Skip to content

build: update karma to v6.3.8 which contains sourcemap generated-code fix #23922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Updates to Karma v6.3.8 which contains a sourcemap fix we landed
upstream. Previous versions of Karma printed/polluted the log output
when an error is thrown due to generated-code being part of stack
traces (due to ESBuild downleveling).

More details here:
https://gist.github.com/devversion/549d25915c2dc98a8896ba4408a1e27c.

karma-runner/karma@4f23b14

Example stack trace in a test which uses async/await (which is downleveled)
image

… fix

Updates to Karma v6.3.8 which contains a sourcemap fix we landed
upstream. Previous versions of Karma printed/polluted the log output
when an error is thrown due to generated-code being part of stack
traces (due to ESBuild downleveling).

More details here:
https://gist.github.com/devversion/549d25915c2dc98a8896ba4408a1e27c.

karma-runner/karma@4f23b14
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 8, 2021
@devversion devversion requested a review from crisbeto November 8, 2021 15:28
@devversion devversion marked this pull request as ready for review November 8, 2021 15:28
@devversion devversion requested a review from a team as a code owner November 8, 2021 15:28
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Nov 8, 2021
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Nov 8, 2021
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amysorto amysorto merged commit f69cf6c into angular:master Nov 9, 2021
amysorto pushed a commit that referenced this pull request Nov 9, 2021
… fix (#23922)

Updates to Karma v6.3.8 which contains a sourcemap fix we landed
upstream. Previous versions of Karma printed/polluted the log output
when an error is thrown due to generated-code being part of stack
traces (due to ESBuild downleveling).

More details here:
https://gist.github.com/devversion/549d25915c2dc98a8896ba4408a1e27c.

karma-runner/karma@4f23b14
(cherry picked from commit f69cf6c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants