Skip to content

build: update bazel setup to latest dev-infra and rules_nodejs version #23973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

devversion
Copy link
Member

Updates the Bazel setup to the latest dev-infra and rules_nodejs
version. This includes:

  • The removal of the spec-bundling code as that has been moved over to
    the shared dev-infra code.

  • The remoal of the AMD esbuild and devmode JS source extraction as
    these rules have been moved to the shared dev-infra logic.

  • The removal of the Angular linker ESBuild plugin creation as this
    logic is now exposed as shared script in the shared dev-infra package.

@devversion devversion requested review from jelbourn, mmalerba and a team as code owners November 17, 2021 16:28
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 17, 2021
@devversion devversion force-pushed the build/update-bazel-setuü branch 2 times, most recently from c94ac1a to 5704def Compare November 17, 2021 17:10
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Nov 17, 2021
@devversion devversion force-pushed the build/update-bazel-setuü branch from 5704def to f40c36e Compare November 18, 2021 15:46
Updates the Bazel setup to the latest dev-infra and rules_nodejs
version. This includes:

* The removal of the spec-bundling code as that has been moved over to
  the shared dev-infra code.

* The remoal of the AMD esbuild and devmode JS source extraction as
  these rules have been moved to the shared dev-infra logic.

* The removal of the Angular linker ESBuild plugin creation as this
  logic is now exposed as shared script in the shared dev-infra package.
@devversion devversion force-pushed the build/update-bazel-setuü branch from f40c36e to 777d328 Compare November 18, 2021 17:57
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Just the one comment which is more of a entire structure question that would likely be followup or at least a different scope.

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Nov 18, 2021
@zarend zarend added target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release labels Nov 19, 2021
@zarend zarend merged commit 62f4370 into angular:master Nov 19, 2021
@zarend
Copy link
Contributor

zarend commented Nov 19, 2021

Targeted minor due to merge conflict with 13.0.x.. Please create another PR if this needs to go into patch as well.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants