Skip to content

refactor(material-experimental/mdc-list): account for mdc-list handleClick signature change #24076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

Accounts for the mdc-list handleClick signature/semantics change as
with: material-components/material-components-web#7443.

@devversion devversion requested a review from mmalerba as a code owner December 9, 2021 14:35
@devversion devversion force-pushed the refactor/prep-for-mdc-list-breaking-change branch 3 times, most recently from cb4c9e0 to a64bfb7 Compare December 9, 2021 15:05
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for when we land the other PR

…Click signature change

Accounts for the mdc-list handleClick signature/semantics change as
with:
material-components/material-components-web#7443.
@devversion devversion force-pushed the refactor/prep-for-mdc-list-breaking-change branch from a64bfb7 to cabccd2 Compare December 10, 2021 19:58
@devversion devversion requested a review from a team as a code owner December 10, 2021 19:58
@devversion devversion added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Dec 10, 2021
@andrewseguin andrewseguin merged commit 97ec228 into angular:master Dec 10, 2021
andrewseguin pushed a commit that referenced this pull request Dec 10, 2021
…Click signature change (#24076)

Accounts for the mdc-list handleClick signature/semantics change as
with:
material-components/material-components-web#7443.

(cherry picked from commit 97ec228)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants