refactor(cdk/testing): reuse stabilize callback when creating test element #24094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
devversion
approved these changes
Dec 13, 2021
crisbeto
force-pushed
the
cdk-testing-reuse-callback
branch
from
e208bc1 to
24e9cd5
Compare
…ement Any time we were creating a new test element, we were giving it a new stabilization callback. These changes reuse the same one between all elements in order to reduce the amount of memory for each element.
crisbeto
force-pushed
the
cdk-testing-reuse-callback
branch
from
24e9cd5 to
4d83618
Compare
crisbeto
commented
Dec 13, 2021
| this._rootElement = this._rootElement || this.createTestElement(this.rawRootElement); | ||
| return this._rootElement; | ||
| } | ||
| set rootElement(element: TestElement) { |
There was a problem hiding this comment.
Not a fan of this getter/setter, but the problem is that this class calls createTestElement in the constructor before the sub-classes have had a change to assign the stabilization method.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any time we were creating a new test element, we were giving it a new stabilization callback. These changes reuse the same one between all elements in order to reduce the amount of memory for each element.