Skip to content

build: ignore integration test sub-projects within renovate #24321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

Sub-projects do not necessarily have valid package.json files
because they might reference local-built packages through file:<..>

Renovate does not install dependencies on the top-level workspace
first, neither does it perform a build. We want to ignore such nested
sub-projects as these should be updated manually, ideally even kept
up-to-date by pointing from the sub-workspace to the root workspace
(using e.g. file:/../../node_modules/rxjs).

Relevant issue: #24318

Sub-projects do not necessarily have valid `package.json` files
because they might reference local-built packages through `file:<..>`

Renovate does not install dependencies on the top-level workspace
first, neither does it perform a build. We want to ignore such nested
sub-projects as these should be updated manually, ideally even kept
up-to-date by pointing from the sub-workspace to the root workspace
(using e.g. `file:/../../node_modules/rxjs`).
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Jan 31, 2022
@devversion devversion requested a review from a team as a code owner January 31, 2022 12:50
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Jan 31, 2022
@amysorto amysorto merged commit 5290226 into angular:master Jan 31, 2022
amysorto pushed a commit that referenced this pull request Jan 31, 2022
Sub-projects do not necessarily have valid `package.json` files
because they might reference local-built packages through `file:<..>`

Renovate does not install dependencies on the top-level workspace
first, neither does it perform a build. We want to ignore such nested
sub-projects as these should be updated manually, ideally even kept
up-to-date by pointing from the sub-workspace to the root workspace
(using e.g. `file:/../../node_modules/rxjs`).

(cherry picked from commit 5290226)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants