Skip to content

build: remove mdc-sidenav package #24402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

crisbeto
Copy link
Member

The package was set up some time ago, but we never ended up using it. These changes remove the package so we don't have to keep mantaining its boilerplate.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent merge safe target: patch This PR is targeted for the next patch release labels Feb 12, 2022
@crisbeto crisbeto requested a review from devversion February 12, 2022 08:01
The package was set up some time ago, but we never ended up using it. These changes remove the package so we don't have to keep mantaining its boilerplate.
@crisbeto crisbeto force-pushed the mdc-sidenav-cleanup branch from 83f3672 to 588ba5e Compare February 12, 2022 08:06
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 12, 2022
@wagnermaciel wagnermaciel merged commit fd745d1 into angular:master Feb 15, 2022
wagnermaciel pushed a commit that referenced this pull request Feb 15, 2022
The package was set up some time ago, but we never ended up using it. These changes remove the package so we don't have to keep mantaining its boilerplate.

(cherry picked from commit fd745d1)
amysorto pushed a commit to amysorto/components that referenced this pull request Feb 15, 2022
The package was set up some time ago, but we never ended up using it. These changes remove the package so we don't have to keep mantaining its boilerplate.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants