Skip to content

refactor(multiple): disable CSS variable fallbacks in MDC components #24415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2022
Merged

refactor(multiple): disable CSS variable fallbacks in MDC components #24415

merged 1 commit into from
Feb 18, 2022

Conversation

crisbeto
Copy link
Member

Since we don't support IE, we don't have to include a fallback for CSS variables in the MDC components.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Feb 15, 2022
@crisbeto crisbeto force-pushed the disable-variable-fallbacks branch from 9651b86 to 5ab8b84 Compare February 15, 2022 09:55
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Feb 15, 2022
@andrewseguin
Copy link
Contributor

Tests pass, just needs a quick rebase

@crisbeto
refactor(multiple): disable CSS variable fallbacks in MDC components
6d6afcf 
Since we don't support IE, we don't have to include a fallback for CSS variables in the MDC components.
@crisbeto crisbeto force-pushed the disable-variable-fallbacks branch from 5ab8b84 to 6d6afcf Compare February 18, 2022 07:29
@crisbeto
Copy link
Member Author

Rebased.

@andrewseguin andrewseguin merged commit a3840ed into angular:master Feb 18, 2022
andrewseguin pushed a commit that referenced this pull request Feb 18, 2022
@crisbeto @andrewseguin
refactor(multiple): disable CSS variable fallbacks in MDC components (#…
2f949e2 
…24415)

Since we don't support IE, we don't have to include a fallback for CSS variables in the MDC components.

(cherry picked from commit a3840ed)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @andrewseguin @devversion