Skip to content

build: install snapshot builds for angular-devkit and schematics #24458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

devversion
Copy link
Member

Our snapshot build jobs should also install the snapshots for the devkit
and schematics packages (owned by the tooling team). These need to match
up with the CLI package that is currently already updated by the snapshot
setup script.

Our snapshot build jobs should also install the snapshots for the devkit
and schematics packages (owned by the tooling team). These need to match
up with the CLI package that is currently already updated by the snapshot
setup script.
@devversion devversion force-pushed the build/snapshot-cli-builds branch 2 times, most recently from bcc4b19 to ac907d6 Compare February 22, 2022 10:36
@devversion devversion marked this pull request as ready for review February 22, 2022 10:37
@devversion devversion requested a review from a team as a code owner February 22, 2022 10:37
@devversion devversion requested a review from crisbeto February 22, 2022 10:37
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Feb 22, 2022
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Feb 22, 2022
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin merged commit 1c44c17 into angular:master Feb 22, 2022
andrewseguin pushed a commit that referenced this pull request Feb 22, 2022
)

* build: install snapshot builds for angular-devkit and schematics

Our snapshot build jobs should also install the snapshots for the devkit
and schematics packages (owned by the tooling team). These need to match
up with the CLI package that is currently already updated by the snapshot
setup script.

* fixup! build: install snapshot builds for angular-devkit and schematics

Make code a little more readable

(cherry picked from commit 1c44c17)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants