-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/sort): remove role from header when disabled #24477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the sort header is disabled, we make it non-interactive by clearing its `tabindex`, however it still has the `role="button"` which can throw off screen readers if it doesn't have text. These changes also clear the `role` from the header if it's disabled.
andrewseguin
approved these changes
Feb 24, 2022
crisbeto
added a commit
that referenced
this pull request
Feb 24, 2022
When the sort header is disabled, we make it non-interactive by clearing its `tabindex`, however it still has the `role="button"` which can throw off screen readers if it doesn't have text. These changes also clear the `role` from the header if it's disabled. (cherry picked from commit 229dd6e)
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Mar 8, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fcdk/13.2.4/13.2.5) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`13.2.4` -> `13.2.5`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/13.2.4/13.2.5) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v13.2.5`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1325-satin-sash-2022-03-02) [Compare Source](angular/components@13.2.4...13.2.5) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [9e34a0f69f](angular/components@9e34a0f) | fix | **drag-drop:** error if preview dimensions are accessed too early ([#​24498](angular/components#24498)) | | [9be3c46b01](angular/components@9be3c46) | fix | **testing:** TestElement sendKeys method should throw if no keys have been specified ([#​18271](angular/components#18271)) | | [8e57a89cba](angular/components@8e57a89) | perf | **overlay:** add event listeners for overlay dispatchers outside of zone ([#​24408](angular/components#24408)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [ed2f516401](angular/components@ed2f516) | fix | **autocomplete:** auto-highlighted first option not display correctly if the floating label is disabled ([#​14507](angular/components#14507)) | | [502102116e](angular/components@5021021) | fix | **autocomplete:** don't block default arrow keys when using modifiers ([#​11987](angular/components#11987)) | | [f31fd3f066](angular/components@f31fd3f) | fix | **autocomplete:** reopen panel on input click ([#​16020](angular/components#16020)) | | [5a79042d7d](angular/components@5a79042) | fix | **button-toggle:** use solid border color ([#​14253](angular/components#14253)) | | [e2d4eecfcb](angular/components@e2d4eec) | fix | **checkbox:** inconsistent disabled color ([#​23083](angular/components#23083)) | | [005ec323de](angular/components@005ec32) | fix | **checkbox:** incorrect text color when placed inside an overlay with a dark theme ([#​19054](angular/components#19054)) | | [d7cbd1315f](angular/components@d7cbd13) | fix | **datepicker:** matDatepickerParse error not being added on first invalid value ([#​11524](angular/components#11524)) | | [046022f31d](angular/components@046022f) | fix | **datepicker:** use aria-live over cdkAriaLive on period button ([#​24398](angular/components#24398)) | | [37f69dbf7e](angular/components@37f69db) | fix | **dialog:** use passed in ComponentFactoryResolver to resolve dialog content ([#​17710](angular/components#17710)) | | [2e15f54a9f](angular/components@2e15f54) | fix | **menu:** focus lost if active item is removed ([#​14039](angular/components#14039)) | | [ea07fa8e64](angular/components@ea07fa8) | fix | **progress-spinner:** unable to change mode on spinner directive ([#​14514](angular/components#14514)) | | [1a498a6a81](angular/components@1a498a6) | fix | **sort:** remove role from header when disabled ([#​24477](angular/components#24477)) | | [72019531db](angular/components@7201953) | fix | **tooltip:** don't hide when pointer moves to tooltip ([#​24475](angular/components#24475)) | ##### material-experimental | Commit | Type | Description | | -- | -- | -- | | [7b85cc077c](angular/components@7b85cc0) | fix | **mdc-button:** density styles being overwritten by structural styles ([#​22736](angular/components#22736)) | | [aeb1426e4c](angular/components@aeb1426) | fix | **mdc-chips:** expose avatar harness ([#​24499](angular/components#24499)) | #### Special Thanks Andrew Seguin, Artur Androsovych, Jeri Peier, Kristiyan Kostadinov, Paul Gschwendtner, Yousaf Nawaz and Zach Arend <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1199 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Accessibility
This issue is related to accessibility (a11y)
action: merge
The PR is ready for merge by the caretaker
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the sort header is disabled, we make it non-interactive by clearing its
tabindex
, however it still has therole="button"
which can throw off screen readers if it doesn't have text.These changes also clear the
role
from the header if it's disabled.