build: prepare framework peer dependency and migration collection for v14 #24492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… v14 Prepares the framework peer dependency and migration collection for v14, ensuring the release checks will not fail when we get closer to publishing the first RC.
The chalk usages in the `tools/` folder seems to fail at runtime given the `esModuleInterop` flag being enabled for the tools folder. We need to switch the namespace imports to default imports to work with the interop, and to follow the TS language-service recommendation (which actually proposes switching these imports to `import c from 'chalk'`) We should likely turn on the esmoduleinterop flag for the scripts folder as well to have consistent imports, and to prepare for future ESM consumption as the ecosystem moves forward.
devversion
added
merge safe
target: major
andrewseguin
approved these changes
Feb 28, 2022
|
@crisbeto / @andrewseguin - I pushed another commit if you could please review that one. Basically everything except for the (still CommonJS) schematics would consistently use the ES module interop in this repo (similar to how it's done in FW) |
Similar to the `/tsconfig.json` and the `tools/tsconfig.json`, we should enable the `esModuleInterop` from TypeScript in the `scripts/` directory. This is necessary to ensure that scripts part of both compilations. e.g. when a file in `scripts/` imports from `tools/` are compatible without needing two coordinated compilations (using e.g TS project references..). In general enabling the interop means more consistency in the repo. Then only remaining exception are the schematics which we can clean-up in the future when we ship them as ES modules.
devversion
force-pushed
the
prepare-v14-release
branch
from
f50f476 to
3f1b2d6
Compare
crisbeto
approved these changes
Feb 28, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits