Skip to content

docs(material/datepicker): require confirmation buttons for a11y #24526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

zarend
Copy link
Contributor

@zarend zarend commented Mar 5, 2022

docs(material/datepicker): require confirmation buttons for a11y

For the datepicker accessiblity documentation, add instructions to always
provide confirmation buttons. This prevents an accessibility issue where
selecting a date on the calendar gives no audio feedback of the selected date
(#23568).

This commit only affects the docs and does not change source code.

Addresses #23568

@zarend zarend requested a review from jelbourn March 5, 2022 01:05
@zarend zarend force-pushed the datepicker-docs branch from de292db to 5458587 Compare March 7, 2022 22:42
@zarend zarend changed the title docs(material/datepicker): a11y, require confirmation buttons docs(material/datepicker): require confirmation buttons for a11y Mar 7, 2022
@zarend zarend added dev-app preview When applied, previews of the dev-app are deployed to Firebase Accessibility This issue is related to accessibility (a11y) area: material/datepicker labels Mar 7, 2022
@zarend zarend marked this pull request as ready for review March 7, 2022 22:45
@zarend zarend requested a review from mmalerba as a code owner March 7, 2022 22:45
@zarend zarend requested a review from twerske March 7, 2022 22:45
@zarend
Copy link
Contributor Author

zarend commented Mar 7, 2022

cc @twerske as you might be interested in this 👋

@zarend zarend requested a review from crisbeto March 7, 2022 22:49
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

@zarend zarend added the target: patch This PR is targeted for the next patch release label Mar 8, 2022
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

For the datepicker accessiblity documentation, add instructions to always
provide confirmation buttons. This prevents an accessibility issue where
selecting a date on the calendar gives no audio feedback of the selected date
(angular#23568).

This commit only affects the docs and does not change source code.

Addresses angular#23568
@zarend zarend added the action: merge The PR is ready for merge by the caretaker label Mar 10, 2022
@zarend zarend merged commit ceae061 into angular:master Mar 10, 2022
zarend added a commit that referenced this pull request Mar 10, 2022
)

For the datepicker accessiblity documentation, add instructions to always
provide confirmation buttons. This prevents an accessibility issue where
selecting a date on the calendar gives no audio feedback of the selected date
(#23568).

This commit only affects the docs and does not change source code.

Addresses #23568

(cherry picked from commit ceae061)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…ular#24526)

For the datepicker accessiblity documentation, add instructions to always
provide confirmation buttons. This prevents an accessibility issue where
selecting a date on the calendar gives no audio feedback of the selected date
(angular#23568).

This commit only affects the docs and does not change source code.

Addresses angular#23568
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker area: material/datepicker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants