feat(cdk-experimental/menu): Use DI instead of CdkMenuPanel to connect menus #24558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalerba
force-pushed
the
cdk-menu-api-2
branch
from
65ff045 to
c5fa21a
Compare
mmalerba
changed the title
mmalerba
force-pushed
the
cdk-menu-api-2
branch
from
c5fa21a to
ce9e8fe
Compare
mmalerba
commented
Mar 10, 2022
mmalerba
force-pushed
the
cdk-menu-api-2
branch
from
0680658 to
e989930
Compare
mmalerba
added
action: merge
mmalerba
force-pushed
the
cdk-menu-api-2
branch
from
e989930 to
36d3282
Compare
mmalerba
force-pushed
the
cdk-menu-api-2
branch
from
36d3282 to
f780d1a
Compare
mmalerba
force-pushed
the
cdk-menu-api-2
branch
from
efda395 to
c01a543
Compare
mmalerba
added
action: merge
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…t menus (angular#24558) * feat(cdk-experimental/menu): Use DI instead of CdkMenuPanel to connect menus * fixup! feat(cdk-experimental/menu): Use DI instead of CdkMenuPanel to connect menus * fixup! feat(cdk-experimental/menu): Use DI instead of CdkMenuPanel to connect menus
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to simplify the API by eliminating
MenuPanel, which was a directive that existed purely to glue together other components and directives. Specifically it was used to pass along theMenuStackand to associate aMenuwith the trigger that opened it.In the reworked API,
MenuStackbecomes injectable and we create a new base class for all menu triggers,MenuTriggerthat is also injectable. The new injectables work as follows:MenuTriggerprovide bothMenuStackandMenuTriggerto anyMenuthey openMenuinjects an optionalMenuStackandMenuTriggerMenuregisters with its injectedMenuStackandMenuTriggeratngOnInit