Skip to content

build: ship schematics as es2020 similar to rest of the APF #24575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

devversion
Copy link
Member

As part of v13, we manually added the prodmode/devmode target to schematic
build targets and set it to es2015. This was done since we still supported
NodeJS v12. This is no longer the case with v14 and we already removed the
NodeJS v12 integration test, so we can also remove the target override.

As part of v13, we manually added the prodmode/devmode target to schematic
build targets and set it to `es2015`. This was done since we still supported
NodeJS v12. This is no longer the case with v14 and we already removed the
NodeJS v12 integration test, so we can also remove the target override.
@devversion devversion requested a review from crisbeto March 11, 2022 13:38
@devversion devversion added merge safe target: major This PR is targeted for the next major release labels Mar 11, 2022
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Mar 11, 2022
@zarend zarend merged commit 21198fe into angular:master Mar 14, 2022
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
…r#24575)

As part of v13, we manually added the prodmode/devmode target to schematic
build targets and set it to `es2015`. This was done since we still supported
NodeJS v12. This is no longer the case with v14 and we already removed the
NodeJS v12 integration test, so we can also remove the target override.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants