Pin actions to a full length commit SHA #24647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveensrinivasan
force-pushed
the
naveen/feat/pin-deps
branch
from
7669cac to
94f77fc
Compare
devversion
reviewed
Mar 23, 2022
There was a problem hiding this comment.
Thanks for this PR, can you also please fix the commit message?
cc. @clydin
- Pinned actions by SHA https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies - Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions
naveensrinivasan
force-pushed
the
naveen/feat/pin-deps
branch
from
94f77fc to
63f21f5
Compare
devversion
approved these changes
Mar 23, 2022
|
@devversion Let me know if something else is missing. Thanks for the quick review and turnaround appreciate it! |
Signed-off-by: naveensrinivasan <[email protected]>
naveensrinivasan
force-pushed
the
naveen/feat/pin-deps
branch
from
cfa2951 to
30f6537
Compare
devversion
approved these changes
Mar 23, 2022
devversion
added
action: merge
|
@devversion What is that needed to merge this in? |
andrewseguin
pushed a commit
that referenced
this pull request
Mar 24, 2022
* build: Pin actions to a full length commit SHA - Pinned actions by SHA https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies - Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions * build: Fixed the incorrect SHA's Signed-off-by: naveensrinivasan <[email protected]> (cherry picked from commit 8ae8216)
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
* build: Pin actions to a full length commit SHA - Pinned actions by SHA https://github.com/ossf/scorecard/blob/main/docs/checks.md#pinned-dependencies - Included permissions for the action. https://github.com/ossf/scorecard/blob/main/docs/checks.md#token-permissions * build: Fixed the incorrect SHA's Signed-off-by: naveensrinivasan <[email protected]>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions#using-third-party-actions
Also, dependabot supports upgrading based on SHA.
Signed-off-by: naveensrinivasan [email protected]
Other angular projects are doing similar stuff https://github.com/angular/angular-cli/blob/366cabc66c3dd836e2fdfea8dad6c4c7c2096b1d/.github/workflows/dev-infra.yml#L16
https://github.com/angular/angular/blob/8155428ba65c38c0c15f2666727202a7b360c1bd/.github/workflows/feature-requests.yml#L10