Skip to content

build: use github access token for docs site monitoring #24691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

We recently seemed to hit the rate limit in the docs site monitoring
job. We can use a Github access token to avoid these rate limit failures.

We move the token extraction to a common location where the GCP key is
also extracted, and we use a more granular variable name to make sure it's
obvious where the key is used (when added to CircleCI)

We recently seemed to hit the rate limit in the docs site monitoring
job. We can use a Github access token to avoid these rate limit failures.

We move the token extraction to a common location where the GCP key is
also extracted, and we use a more granular variable name to make sure it's
obvious where the key is used (when added to CircleCI)
@devversion devversion added merge safe target: patch This PR is targeted for the next patch release labels Mar 29, 2022
@devversion devversion requested a review from crisbeto March 29, 2022 11:16
@devversion devversion requested a review from a team as a code owner March 29, 2022 11:16
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added the action: merge The PR is ready for merge by the caretaker label Mar 29, 2022
@andrewseguin andrewseguin merged commit 8a5017d into angular:master Mar 29, 2022
andrewseguin pushed a commit that referenced this pull request Mar 29, 2022
We recently seemed to hit the rate limit in the docs site monitoring
job. We can use a Github access token to avoid these rate limit failures.

We move the token extraction to a common location where the GCP key is
also extracted, and we use a more granular variable name to make sure it's
obvious where the key is used (when added to CircleCI)

(cherry picked from commit 8a5017d)
forsti0506 pushed a commit to forsti0506/components that referenced this pull request Apr 3, 2022
We recently seemed to hit the rate limit in the docs site monitoring
job. We can use a Github access token to avoid these rate limit failures.

We move the token extraction to a common location where the GCP key is
also extracted, and we use a more granular variable name to make sure it's
obvious where the key is used (when added to CircleCI)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants