-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(cdk/menu): update docs to reflect current implementation and add correct role for triggers #24884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mostly minor grammar nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
One thing that occurred to me for a potential follow-up PR is documenting the CSS classes applied by the cdk menu directives
I added a section about CSS classes to this PR, but its pretty boring... all of the classes but one were just static always-applied classes. I guess there's a few options for what we could do with the CSS classes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Repeating here from our conversation earlier for posterity:
I think the CSS classes are useful for both inheriting the directives and for when we can do directives on host elements
correct role for triggers
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.