refactor(material-experimental/mdc-checkbox): remove usage of MDC adapter #24922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion and
mmalerba
as code owners
crisbeto
force-pushed
the
mdc-checkbox-no-adapter
branch
2 times, most recently
from
122f4ae to
2dad28d
Compare
mmalerba
added
the
dev-app preview
mmalerba
reviewed
May 16, 2022
|
Deployed dev-app to: https://ng-comp-dev--pr-24922-7ffd195f572f93b75380126880361129-5a78mrge.web.app |
…pter Moves all of the checkbox logic into a base class which is used to replace the MDC checkbox adapter.
crisbeto
force-pushed
the
mdc-checkbox-no-adapter
branch
from
2dad28d to
7ffd195
Compare
|
Feedback has been addressed. |
|
Assigning this to myself since I ran the presubmit already. |
mmalerba
approved these changes
May 16, 2022
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all of the checkbox logic into a base class which is used to replace the MDC checkbox adapter.