Add HCM disabled styles for stepper and tabs #25393
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
Accessibility
crisbeto
reviewed
Aug 3, 2022
| // color, which is (unintuitively) named "GrayText". | ||
| @include cdk.high-contrast(active, off) { | ||
| &[aria-disabled="true"] { | ||
| color: GrayText; |
There was a problem hiding this comment.
There's also a DisabledText color IIRC. Should we be using that instead?
There was a problem hiding this comment.
Nevermind, I just double-checked it and it's indeed GreyText. We may want to check it against Firefox though since I saw this comment: https://github.com/angular/components/blob/main/src/material/legacy-core/option/option.scss#L40
|
lmk if you want me to test this on Windows. |
jelbourn
force-pushed
the
hcm-disables-style
branch
from
1e917b7 to
07deb15
Compare
|
I tested this in Chrome on Windows (on my personal PC), but I did forget to test Firefox. I'll double check it tomorrow when I WFH. |
This adds disabled styles for stepper header in high contrast mode
This adds disabled styles for tab labels in high contrast mode
jelbourn
force-pushed
the
hcm-disables-style
branch
from
07deb15 to
e2d65d7
Compare
|
Just tested this on Firefox and it looks right |
wagnermaciel
added
target: rc
wagnermaciel
pushed a commit
that referenced
this pull request
Nov 6, 2022
* fix(material/stepper): add HCM disabled styles This adds disabled styles for stepper header in high contrast mode * fix(material/tabs): add HCM disabled styles This adds disabled styles for tab labels in high contrast mode (cherry picked from commit bdec140)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Nov 7, 2022
* fix(material/stepper): add HCM disabled styles This adds disabled styles for stepper header in high contrast mode * fix(material/tabs): add HCM disabled styles This adds disabled styles for tab labels in high contrast mode
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Nov 7, 2022
* fix(material/stepper): add HCM disabled styles This adds disabled styles for stepper header in high contrast mode * fix(material/tabs): add HCM disabled styles This adds disabled styles for tab labels in high contrast mode
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Nov 7, 2022
…ngular#25393) * fix(material/stepper): add HCM disabled styles This adds disabled styles for stepper header in high contrast mode * fix(material/tabs): add HCM disabled styles This adds disabled styles for tab labels in high contrast mode
wagnermaciel
added a commit
that referenced
this pull request
Nov 7, 2022
…25393) (#25932) * fix(material/stepper): add HCM disabled styles This adds disabled styles for stepper header in high contrast mode * fix(material/tabs): add HCM disabled styles This adds disabled styles for tab labels in high contrast mode Co-authored-by: Jeremy Elbourn <[email protected]>
crapStone
pushed a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Nov 11, 2022
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@angular/cdk](https://github.com/angular/components) | dependencies | patch | [`14.2.6` -> `14.2.7`](https://renovatebot.com/diffs/npm/@angular%2fcdk/14.2.6/14.2.7) | | [@angular/material](https://github.com/angular/components) | dependencies | patch | [`14.2.6` -> `14.2.7`](https://renovatebot.com/diffs/npm/@angular%2fmaterial/14.2.6/14.2.7) | --- ### Release Notes <details> <summary>angular/components</summary> ### [`v14.2.7`](https://github.com/angular/components/blob/HEAD/CHANGELOG.md#​1427-smoke-spirit-2022-11-09) [Compare Source](angular/components@14.2.6...14.2.7) ##### cdk | Commit | Type | Description | | -- | -- | -- | | [f63918a3b8](angular/components@f63918a) | fix | **scrolling:** error when querying for CdkVirtualScrollViewport as CdkScrollable ([#​25937](angular/components#25937)) | ##### material | Commit | Type | Description | | -- | -- | -- | | [53588b51d2](angular/components@53588b5) | fix | **stepper:** add HCM disabled styles for stepper and tabs ([#​25393](angular/components#25393)) ([#​25932](angular/components#25932)) | | [a1473b93fc](angular/components@a1473b9) | fix | **stepper:** content not visibile on first navigation when nested in tabs ([#​25930](angular/components#25930)) | #### Special Thanks Douglas Parker, Kristiyan Kostadinov and Wagner Maciel <!-- CHANGELOG SPLIT MARKER --> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4yMS4yIiwidXBkYXRlZEluVmVyIjoiMzQuMjIuMSJ9--> Co-authored-by: cabr2-bot <[email protected]> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1635 Reviewed-by: Epsilon_02 <[email protected]> Co-authored-by: Calciumdibromid Bot <[email protected]> Co-committed-by: Calciumdibromid Bot <[email protected]>
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.