Skip to content

test(material/legacy-chips): fix selectable chips tests #25790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

crisbeto
Copy link
Member

Fixes that we had some tests where we were testing user selection of a chip, but the chip wasn't set as selectable.

Setting this as a P2, because it's blocking angular/angular#47576.

Fixes that we had some tests where we were testing user selection of a chip, but the chip wasn't set as selectable.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: major This PR is targeted for the next major release labels Oct 11, 2022
@crisbeto crisbeto requested a review from devversion October 11, 2022 10:36
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Oct 11, 2022
@crisbeto crisbeto merged commit 87eb708 into angular:main Oct 11, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants