Skip to content

build: setup action for identifying changes needing to be tested in google #25931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 8, 2022

Conversation

devversion
Copy link
Member

See individual commits

angular-robot and others added 3 commits November 7, 2022 13:24
…oogle

This will be the public part of the Angular Presubmit Status service. We
will be able to remove the `merge safe` label- but for now we keep it
until we decide what to do with it. I could also imagine this action
automatically applying such a label for better filtering.

At the same time though, for a caretaker it should likely not matter
because the GitHub status checks are sufficient indicator (now with the
new service) whether a PR is ready or not.
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added target: rc This PR is targeted for the next release-candidate action: merge The PR is ready for merge by the caretaker merge safe target: minor This PR is targeted for the next minor release and removed target: rc This PR is targeted for the next release-candidate labels Nov 7, 2022
@devversion devversion merged commit 60cda52 into angular:main Nov 8, 2022
devversion added a commit that referenced this pull request Nov 8, 2022
…oogle (#25931)

* build: update angular shared dev-infra code

* build: update ng-dev configuration to account for deleted config options

* build: setup action for identifying changes needing to be tested in google

This will be the public part of the Angular Presubmit Status service. We
will be able to remove the `merge safe` label- but for now we keep it
until we decide what to do with it. I could also imagine this action
automatically applying such a label for better filtering.

At the same time though, for a caretaker it should likely not matter
because the GitHub status checks are sufficient indicator (now with the
new service) whether a PR is ready or not.

Co-authored-by: Angular Robot <[email protected]>
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants