Skip to content

fix(material/datepicker): fix date picker shortcuts #25951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2022

Conversation

sasidharansd
Copy link
Contributor

Fixes a bug in the Angular Material datepicker component where the datepicker should open/close only on alt+down and alt+up respectively but using shift + ctrl + alt + down or ctrl + alt + down the datepicker was opening, and same happens for closing the date picker added a condition to check if ctrl, shift or meta keys are present and if it is present restricting datepicker to not to open/close.

Fixes #25868

Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmalerba mmalerba added action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Nov 11, 2022
@mmalerba
Copy link
Contributor

@sasidharansd can you run yarn bazel run //tools/public_api_guard:cdk/keycodes.md_api.accept to approve the API change?

Fixes a bug in the Angular Material `datepicker` component where the
datepicker should open/close only on alt+down and alt+up respectively
but using shift + ctrl + alt + down or ctrl + alt + down the datepicker
was opening, and same happens for closing the date picker added a
condition to check if ctrl, shift or meta keys are present and if it
is present restricting datepicker to not to open/close.

Fixes angular#25868
Fixes a bug in the Angular Material datepicker component where the datepicker should open/close only on alt+down and alt+up respectively but using shift + ctrl + alt + down or ctrl + alt + down the datepicker was opening, and same happens for closing the date picker added a condition to check if ctrl, shift or meta keys are present and if it is present restricting datepicker to not to open/close.

Fixes angular#25868
@sasidharansd
Copy link
Contributor Author

@sasidharansd can you run yarn bazel run //tools/public_api_guard:cdk/keycodes.md_api.accept to approve the API change?

Done, I have ran the cmd and updated the PR.

@sasidharansd
Copy link
Contributor Author

@mmalerba This is my first time contributing. Could you please help me to know. is there anything that I should be doing more or is everything done from my end and I should be wait for the pr to be reviewed ?

@mmalerba
Copy link
Contributor

There is nothing to be done on your end for the moment. We need to run this against Google's internal tests and make sure everything passes. We'll reach out if there are issues

@mmalerba mmalerba self-assigned this Nov 29, 2022
@mmalerba mmalerba merged commit d02cc68 into angular:main Nov 29, 2022
@mmalerba mmalerba assigned mmalerba and unassigned mmalerba Nov 29, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(DatePicker): Fix shortcut to open datepicker
2 participants