-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(material/datepicker): fix date picker shortcuts #25951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sasidharansd can you run |
Fixes a bug in the Angular Material `datepicker` component where the datepicker should open/close only on alt+down and alt+up respectively but using shift + ctrl + alt + down or ctrl + alt + down the datepicker was opening, and same happens for closing the date picker added a condition to check if ctrl, shift or meta keys are present and if it is present restricting datepicker to not to open/close. Fixes angular#25868
Fixes a bug in the Angular Material datepicker component where the datepicker should open/close only on alt+down and alt+up respectively but using shift + ctrl + alt + down or ctrl + alt + down the datepicker was opening, and same happens for closing the date picker added a condition to check if ctrl, shift or meta keys are present and if it is present restricting datepicker to not to open/close. Fixes angular#25868
eea660f
to
0524c05
Compare
Done, I have ran the cmd and updated the PR. |
@mmalerba This is my first time contributing. Could you please help me to know. is there anything that I should be doing more or is everything done from my end and I should be wait for the pr to be reviewed ? |
There is nothing to be done on your end for the moment. We need to run this against Google's internal tests and make sure everything passes. We'll reach out if there are issues |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes a bug in the Angular Material
datepicker
component where the datepicker should open/close only on alt+down and alt+up respectively but using shift + ctrl + alt + down or ctrl + alt + down the datepicker was opening, and same happens for closing the date picker added a condition to check if ctrl, shift or meta keys are present and if it is present restricting datepicker to not to open/close.Fixes #25868