fix(cdk/menu): prevent default selection key actions #26051
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes that the CDK menu wasn't calling `preventDefault` on the enter key presses which caused it to immediately close, because it would allow the click handler to fire as well. Fixes angular#26033.
crisbeto
added
P3
crisbeto
requested review from
devversion
and removed request for
devversion
|
Just curious, does this fix will goto version 14.*? |
|
It won't. We generally don't backport fixes unless they're security-related. |
crisbeto
added a commit
that referenced
this pull request
Nov 23, 2022
Closed
1 task
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Dec 20, 2022
In angular#26051 a couple of `preventDefault` calls were added, because we were moving focus within an enter key `keydown` event which was causing the menu to close immediately after it opens. The problem is that the calls also prevent links from navigating. These changes remove the `preventDefault` calls and resolve the initial issue by ignoring clicks initiated by the keyboard. Fixes angular#26291.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that the CDK menu wasn't calling
preventDefaulton the enter key presses which caused it to immediately close, because it would allow the click handler to fire as well.Fixes #26033.