Skip to content

fix(material/chips): initial value from forms not reflected in the view #26052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2022
Merged

fix(material/chips): initial value from forms not reflected in the view #26052

merged 1 commit into from
Nov 23, 2022

Conversation

crisbeto
Copy link
Member

Fixes that the chip listbox wasn't reflecting its initial value in the view, because writeValue gets called initially before the chips have been initialized.

Fixes #26041.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release labels Nov 22, 2022
@crisbeto
fix(material/chips): initial value from forms not reflected in the view
81e7dff 
Fixes that the chip listbox wasn't reflecting its initial value in the view, because `writeValue` gets called initially before the chips have been initialized.

Fixes angular#26041.
@crisbeto crisbeto force-pushed the 26041/chips-forms-initial-value branch from c6a2fca to 81e7dff Compare November 23, 2022 09:17
mmalerba
mmalerba approved these changes Nov 23, 2022
View reviewed changes
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 23, 2022
@crisbeto crisbeto merged commit e6b842c into angular:main Nov 23, 2022
crisbeto added a commit that referenced this pull request Nov 23, 2022
@crisbeto
fix(material/chips): initial value from forms not reflected in the vi…
0cd409e 
…ew (#26052)

Fixes that the chip listbox wasn't reflecting its initial value in the view, because `writeValue` gets called initially before the chips have been initialized.

Fixes #26041.

(cherry picked from commit e6b842c)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@zarend zarend Awaiting requested review from zarend

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(chips): Chip options initial value skipped when using reactive form in v15
2 participants
@crisbeto @mmalerba