-
Notifications
You must be signed in to change notification settings - Fork 6.8k
doc(material/button): improve button docs & examples #26170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove stale README that describes the component as experimental - Add docs describing the extended fab variant - Add aria-labels to button examples that don't have text - Remove "basic" color fabs from example, since fab doesn't support an un-colored style (It probably should as its shown in the spec, but that's outside the scope of this docs fix). - Add extended fab row to example
wagnermaciel
reviewed
Dec 2, 2022
wagnermaciel
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
mmalerba
added a commit
that referenced
this pull request
Dec 4, 2022
* docs(material/button): improve button docs & examples - Remove stale README that describes the component as experimental - Add docs describing the extended fab variant - Add aria-labels to button examples that don't have text - Remove "basic" color fabs from example, since fab doesn't support an un-colored style (It probably should as its shown in the spec, but that's outside the scope of this docs fix). - Add extended fab row to example * fixup! docs(material/button): improve button docs & examples (cherry picked from commit 2629047)
wagnermaciel
pushed a commit
to wagnermaciel/components
that referenced
this pull request
Dec 9, 2022
* docs(material/button): improve button docs & examples - Remove stale README that describes the component as experimental - Add docs describing the extended fab variant - Add aria-labels to button examples that don't have text - Remove "basic" color fabs from example, since fab doesn't support an un-colored style (It probably should as its shown in the spec, but that's outside the scope of this docs fix). - Add extended fab row to example * fixup! docs(material/button): improve button docs & examples
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
action: merge
The PR is ready for merge by the caretaker
area: docs
Related to the documentation
docs
This issue is related to documentation
target: patch
This PR is targeted for the next patch release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19058