Skip to content

fix(material-experimental/popover-edit): Make cell focus indicator vi… #26275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fix(material-experimental/popover-edit): Make cell focus indicator vi… #26275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/material-experimental/popover-edit/_popover-edit-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@
opacity 100ms mat.$private-swift-ease-out-timing-function,
background-color 300ms mat.$private-swift-ease-out-timing-function;
visibility: visible;

@include cdk.high-contrast {
border-bottom: 3px dashed black;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far I've been avoiding using borders for focus indication since they can make the content jump. Would it make sense to use outline here or achieve the same effect with a position: absolute pseudo element?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content will not jump here since this is just a pseudo element that's absolutely positioned. I think border works better because I want only a single dashed line to appear.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And to clarify - this selector is already modifying an absolutely positioned pseudo element.

}
}
}
}
Expand Down