Skip to content

build: update to TypeScript 5.0 #26755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2023
Merged

build: update to TypeScript 5.0 #26755

merged 1 commit into from
Mar 9, 2023

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Mar 9, 2023

Updates the repo to TypeScript 5 and resolves some errors that came up along the way. The most notable one is that none of the Codelyzer lint rules work anymore, because they depended upon deprecated APIs that have been deleted. I decided to reimplement the rule that asserts that lifecycle hook interfaces are present, but the remaining rules didn't seem that useful so I've removed them.

@crisbeto crisbeto added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release labels Mar 9, 2023
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Mar 9, 2023
@crisbeto crisbeto force-pushed the ts-5.0 branch 2 times, most recently from ac26878 to f707ef7 Compare March 9, 2023 08:52
@crisbeto crisbeto requested a review from andrewseguin as a code owner March 9, 2023 08:52
@crisbeto crisbeto force-pushed the ts-5.0 branch 3 times, most recently from 3d67f71 to 8291b5f Compare March 9, 2023 09:21
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Mar 9, 2023
Updates the repo to TypeScript 5 and resolves some errors that came up along the way. The most notable one is that none of the Codelyzer lint rules work anymore, because they depended upon deprecated APIs that have been deleted. I decided to reimplement the rule that asserts that lifecycle hook interfaces are present, but the remaining rules didn't seem that useful so I've removed them.
@crisbeto crisbeto merged commit 1eb83e5 into angular:main Mar 9, 2023
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants