fix(material/tooltip): match panel to trigger in test harness #26779
+24
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
devversion and
josephperrott
as code owners
devversion
approved these changes
Mar 13, 2023
crisbeto
force-pushed
the
26773/tooltip-panel-id
branch
from
5008db0 to
8dfdb10
Compare
crisbeto
force-pushed
the
26773/tooltip-panel-id
branch
from
8dfdb10 to
73ca6f5
Compare
crisbeto
force-pushed
the
26773/tooltip-panel-id
branch
2 times, most recently
from
df7c1f1 to
dfc71a0
Compare
The tooltip harness was written the assumption that only tooltip can be shown on the page at a time, however in tests that might not be the case. These changes add a couple of attributes so a trigger can be matched to its specific panel. Fixes angular#26773.
crisbeto
force-pushed
the
26773/tooltip-panel-id
branch
from
dfc71a0 to
2a1c419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tooltip harness was written the assumption that only tooltip can be shown on the page at a time, however in tests that might not be the case. These changes add a couple of attributes so a trigger can be matched to its specific panel.
Fixes #26773.