refactor(material/expansion): switch to tokens API #27390
Conversation
crisbeto
added
P3
Reworks the expansion panel to use the tokens theming API.
crisbeto
force-pushed
the
expansion-tokens
branch
from
078a1b0 to
eb2a906
Compare
| container-text-color: theming.get-color-from-palette($foreground, text), | ||
| actions-divider-color: theming.get-color-from-palette($foreground, divider), | ||
| header-hover-state-layer-color: theming.get-color-from-palette($background, hover), | ||
| header-focus-state-layer-color: theming.get-color-from-palette($background, hover), |
There was a problem hiding this comment.
ty for including state layer color. Focus states are important for accessibility.
[OPtional] If it's not a lot of work, I suggest adding state layer opacity. We don't need that now, but we will probably need it in the future. I'm okay with hard coding the state layer opacity as 0.12 in get-unthemable-tokens.
There was a problem hiding this comment.
For that we'll have to put the state layer in a separate element (right now it's just a background-color). I'd rather we address it separately, because I'm trying to keep the DOM changes to a minimum since moving the declarations into the base styles already causes a bunch of broken targets.
Reworks the expansion panel to use the tokens theming API. (cherry picked from commit b6ce8cc)
Reworks the expansion panel to use the tokens theming API.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Reworks the expansion panel to use the tokens theming API.