fix(material/autocomplete): blocking events to other overlays when there are no results #27432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
andrewseguin
approved these changes
Jul 11, 2023
…ere are no results The autocomplete trigger attaches an overlay even if there are no options in the list. It also subscribes to keydown events and clicks while the panel is open which block events from reaching other overlays. This means that if the user focuses an autocomplete input with no options, the events from it won't reach other overlays. These changes resolve the issue by subcribing and unsubscribing from the event streams depending on the visibility state of the panel. Fixes angular#26479.
crisbeto
force-pushed
the
26479/autocomplete-event-handling
branch
from
e373046 to
1d7e476
Compare
crisbeto
added a commit
that referenced
this pull request
Jul 11, 2023
…ere are no results (#27432) The autocomplete trigger attaches an overlay even if there are no options in the list. It also subscribes to keydown events and clicks while the panel is open which block events from reaching other overlays. This means that if the user focuses an autocomplete input with no options, the events from it won't reach other overlays. These changes resolve the issue by subcribing and unsubscribing from the event streams depending on the visibility state of the panel. Fixes #26479. (cherry picked from commit ff2a3cc)
stephenrca
pushed a commit
to stephenrca/components
that referenced
this pull request
Aug 2, 2023
…ere are no results (angular#27432) The autocomplete trigger attaches an overlay even if there are no options in the list. It also subscribes to keydown events and clicks while the panel is open which block events from reaching other overlays. This means that if the user focuses an autocomplete input with no options, the events from it won't reach other overlays. These changes resolve the issue by subcribing and unsubscribing from the event streams depending on the visibility state of the panel. Fixes angular#26479.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The autocomplete trigger attaches an overlay even if there are no options in the list. It also subscribes to keydown events and clicks while the panel is open which block events from reaching other overlays. This means that if the user focuses an autocomplete input with no options, the events from it won't reach other overlays.
These changes resolve the issue by subcribing and unsubscribing from the event streams depending on the visibility state of the panel.
Fixes #26479.