Skip to content

chore(tools): add syntax highlighting logic for examples #2951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

riavalon
Copy link
Contributor

@riavalon riavalon commented Feb 6, 2017

Also now runs syntax highlighting script in parallel mode

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 6, 2017
@devversion
Copy link
Member

Why aren't we doing this as part of a gulp task?

@riavalon riavalon force-pushed the chore-move-highlight-script-into-repo branch 3 times, most recently from 6908b5f to 89eb93f Compare February 7, 2017 15:40
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should change where the files end up, but lgtm otherwise

.gitignore Outdated
@@ -5,6 +5,7 @@
/tmp
/deploy
/screenshots
/src/examples-highlights
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, it feels a little weird to have built files in the src folder. Can we move this to the root of the repo?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to not bloat the PR. @riavalon why aren't we using the gulp plugin gulp-highlight (here).

This would make the task way smaller and also easier to maintain.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh I see, my bad. I was just moving the script over from the material.angular repo. It would make a lot more sense to use that gulp task. I'll make that change. I can definitely move the built folder to the root as well @kara 👍

@riavalon riavalon force-pushed the chore-move-highlight-script-into-repo branch 3 times, most recently from 8b64c78 to 7588df4 Compare February 8, 2017 17:31
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riavalon riavalon force-pushed the chore-move-highlight-script-into-repo branch from 7588df4 to 55aa88b Compare February 8, 2017 17:39
@kara kara added the action: merge The PR is ready for merge by the caretaker label Feb 8, 2017
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally. LGTM!

@tinayuangao tinayuangao merged commit f73fd7d into angular:master Feb 8, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants