-
Notifications
You must be signed in to change notification settings - Fork 6.8k
chore(tools): add syntax highlighting logic for examples #2951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(tools): add syntax highlighting logic for examples #2951
Conversation
Why aren't we doing this as part of a gulp task? |
6908b5f
to
89eb93f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we should change where the files end up, but lgtm otherwise
.gitignore
Outdated
@@ -5,6 +5,7 @@ | |||
/tmp | |||
/deploy | |||
/screenshots | |||
/src/examples-highlights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, it feels a little weird to have built files in the src folder. Can we move this to the root of the repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahh I see, my bad. I was just moving the script over from the material.angular repo. It would make a lot more sense to use that gulp task. I'll make that change. I can definitely move the built folder to the root as well @kara 👍
8b64c78
to
7588df4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
7588df4
to
55aa88b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it locally. LGTM!
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Also now runs syntax highlighting script in parallel mode