Skip to content

feat(material/card): support filled variant #29868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

naaajii
Copy link
Contributor

@naaajii naaajii commented Oct 12, 2024

feat(material/card): support filled variant

this commit add filled variant for material card which provides subtle seperation from background and has less emphasis than elevated or outlined cards

fixes #29840


docs(material/card): add each appearance example

update the example to contain elevated, outlined & filled variants


image
image


I tried to have a swing at this and it might be not perfect.

@naaajii naaajii requested a review from a team as a code owner October 12, 2024 00:38
@naaajii naaajii requested review from crisbeto and mmalerba and removed request for a team October 12, 2024 00:38
@angular-robot angular-robot bot added detected: feature PR contains a feature commit area: docs Related to the documentation labels Oct 12, 2024
@mmalerba mmalerba added target: major This PR is targeted for the next major release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note action: merge The PR is ready for merge by the caretaker labels Feb 19, 2025
@mmalerba
Copy link
Contributor

Caretaker note: will need to add internal equivalents for the newly defined tokens

@mmalerba
Copy link
Contributor

mmalerba commented Apr 1, 2025

This needs rebase, @andrewseguin has been making some changes to how the tokens are organized

@naaajii
Copy link
Contributor Author

naaajii commented Apr 1, 2025

ERROR: D:/open-source/components/BUILD.bazel:16:22: Extracting npm package [email protected] [for tool] failed: (Exit 1): tar.exe failed: error executing command (from target //:.aspect_rules_js/node_modules/[email protected]/pkg) external\bsd_tar_windows_amd64\tar.exe --extract --no-same-owner --no-same-permissions --strip-components 1 --file external/npm2__yargs-parser__21.1.1/package.tgz --directory ... (remaining 1 argument skipped)
tar.exe: Error opening archive: Can't initialize filter; unable to run program "gzip -d"
Target //src/dev-app:devserver failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 1.286s, Critical Path: 0.21s
INFO: 14 processes: 14 internal.
FAILED: Build did NOT complete successfully

I seem to be running into these issues when running dev-app locally. I will set up a VMware tonight to check changes throughly just in case I didn't miss out something in rebase.

edit: I did also try to install package via choco but still seem to be having issue as referenced here

edit again: I missed alot of things..

@naaajii naaajii force-pushed the feat/29840 branch 3 times, most recently from af0d0f8 to 03848b4 Compare April 1, 2025 22:09
@naaajii
Copy link
Contributor Author

naaajii commented Apr 1, 2025

M3:
image
image

M2:
image
image

@naaajii naaajii force-pushed the feat/29840 branch 4 times, most recently from a9fd590 to b4c330e Compare April 5, 2025 14:22
@andrewseguin andrewseguin self-assigned this Apr 17, 2025
naaajii added 2 commits April 19, 2025 15:52
this commit add `filled` variant for material card which provides subtle seperation from background and has less emphasis than elevated or outlined cards

fixes angular#29840
update the example to contain `elevated`, `outlined` &  `filled` variants
@andrewseguin andrewseguin added dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase labels Apr 24, 2025
Copy link

Deployed dev-app for 318dcb3 to: https://ng-dev-previews-comp--pr-angular-components-29868-dev-iorxya0z.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

Copy link

Deployed docs-preview for 318dcb3 to: https://ng-dev-previews-comp--pr-angular-components-29868-docs-tplx6v1g.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@andrewseguin andrewseguin merged commit 663585a into angular:main Apr 24, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation area: material/card detected: feature PR contains a feature commit dev-app preview When applied, previews of the dev-app are deployed to Firebase docs: preview When applied, a preview of the documentation site is deployed to Firebase merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(card): align card appearance with m3 specs
3 participants