-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(material/card): support filled variant #29868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Caretaker note: will need to add internal equivalents for the newly defined tokens |
This needs rebase, @andrewseguin has been making some changes to how the tokens are organized |
ERROR: D:/open-source/components/BUILD.bazel:16:22: Extracting npm package [email protected] [for tool] failed: (Exit 1): tar.exe failed: error executing command (from target //:.aspect_rules_js/node_modules/[email protected]/pkg) external\bsd_tar_windows_amd64\tar.exe --extract --no-same-owner --no-same-permissions --strip-components 1 --file external/npm2__yargs-parser__21.1.1/package.tgz --directory ... (remaining 1 argument skipped)
tar.exe: Error opening archive: Can't initialize filter; unable to run program "gzip -d"
Target //src/dev-app:devserver failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 1.286s, Critical Path: 0.21s
INFO: 14 processes: 14 internal.
FAILED: Build did NOT complete successfully I seem to be running into these issues when running dev-app locally. I will set up a VMware tonight to check changes throughly just in case I didn't miss out something in rebase. edit: I did also try to install package via choco but still seem to be having issue as referenced here edit again: I missed alot of things.. |
af0d0f8
to
03848b4
Compare
a9fd590
to
b4c330e
Compare
this commit add `filled` variant for material card which provides subtle seperation from background and has less emphasis than elevated or outlined cards fixes angular#29840
update the example to contain `elevated`, `outlined` & `filled` variants
Deployed dev-app for 318dcb3 to: https://ng-dev-previews-comp--pr-angular-components-29868-dev-iorxya0z.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
Deployed docs-preview for 318dcb3 to: https://ng-dev-previews-comp--pr-angular-components-29868-docs-tplx6v1g.web.app Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt. |
feat(material/card): support filled variant
this commit add
filled
variant for material card which provides subtle seperation from background and has less emphasis than elevated or outlined cardsfixes #29840
docs(material/card): add each appearance example
update the example to contain
elevated
,outlined
&filled
variantsI tried to have a swing at this and it might be not perfect.