Skip to content

perf(multiple): Don't double-inject the style loader. #30467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

kseamon
Copy link
Collaborator

@kseamon kseamon commented Feb 10, 2025

inject() is pretty cheap, but not free.

inject() is pretty cheap, but not free.
@kseamon kseamon requested a review from a team as a code owner February 10, 2025 20:58
@kseamon kseamon requested review from andrewseguin and wagnermaciel and removed request for a team February 10, 2025 20:58
@angular-robot angular-robot bot added the area: performance Issues related to performance label Feb 10, 2025
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 11, 2025
@andrewseguin andrewseguin merged commit 1ddb9cf into angular:main Feb 11, 2025
22 of 24 checks passed
andrewseguin pushed a commit that referenced this pull request Feb 11, 2025
inject() is pretty cheap, but not free.

(cherry picked from commit 1ddb9cf)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: performance Issues related to performance target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants