Skip to content

fix(material/form-field): update text field styles for better alignment and overflow handling #30716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

mistrykaran91
Copy link
Contributor

Currently, mat-label overlaps mat-suffix in cases for outline and fill appearance. This fix set the width to inherit and set the notch max-width to same 180px which is same as mat-mdc-form-field-infix

Fixes #28743

@mistrykaran91 mistrykaran91 requested a review from a team as a code owner March 26, 2025 11:15
@mistrykaran91 mistrykaran91 requested review from crisbeto and andrewseguin and removed request for a team March 26, 2025 11:15
@crisbeto
Copy link
Member

I tried something similar in #26353. The problem is that we would have to update the screenshot tests of thousands of internal apps.

@mistrykaran91
Copy link
Contributor Author

I tried something similar in #26353. The problem is that we would have to update the screenshot tests of thousands of internal apps.

Ok, should I revert these changes or try some other way if any ?

@crisbeto
Copy link
Member

There's no way around updating those screenshots. The fact that text truncates differently will cause them to fail.

@mistrykaran91
Copy link
Contributor Author

mistrykaran91 commented Mar 26, 2025

Then better to close MR

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(form-field): mat-label overlap mat-suffix
2 participants