-
Notifications
You must be signed in to change notification settings - Fork 6.8k
feat(material/testing): Extend Angular harness testing functionality #30960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wildcardalice
wants to merge
3
commits into
angular:main
Choose a base branch
from
wildcardalice:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+277
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbb2058
to
d6dac1d
Compare
andrewseguin
approved these changes
Apr 29, 2025
should we switch this to |
harnesses This facilitates testing by making it possible to fetch certain harnesses using their floating label text (mat-label). Previously, the user would have to locate the harness using an id or class, or by calling MatFormFieldHarness.getControl(). This affects the following harnesses: - MatInputHarness - MatSelectHarness - MatNativeSelectHarness - MatDatepickerInputHarness - MatDateRangeInputHarness Tests via unit tests
`getHarnessAtIndex` and `countHarnesses` These two new functions are intended to expand harness testing functionality by providing built-in functions for commonly used patterns. * `getHarnessAtIndex` functions similarly to `getHarness`, but returns a harness for the matching component instance with the given index. An example use case is to fetch the nth MatOptionHarness on screen. * `countHarnesses` simply counts the number of matching component instances and returns the result. Documentation is updated to reflect this changes, and adds a missing row for the `hasHarness` function Manually tested using the MatInputHarness tests
a55f675
to
377b93a
Compare
of floating label functionality to MatFormFieldControlHarness class Adding anything to this abstract class causes compilation issues when using MatFormFieldHarness.getControl(...) to fetch a type other than the directly supported types. The most common problems arise when fetching MatAutocompleteHarness or MatChipGridHarness, but I have found instances of other components such as MatCheckboxHarness. Moving the functionality to a base class resolves this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
action: merge
The PR is ready for merge by the caretaker
area: cdk/dialog
area: cdk/overlay
area: cdk/schematics
cdk/schematics is *not* a public API
area: cdk/table
area: cdk/testing
area: material/button
area: material/button-toggle
area: material/dialog
area: material/stepper
area: material/table
area: material/tabs
area: material/testing
detected: feature
PR contains a feature commit
target: major
This PR is targeted for the next major release
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the following functionalities to the harness test kit
getHarnessAtIndex
This new function works acts like
getHarness
, but returns an instance of the harness corresponding to the matching element at the given index. This throws an error if the index is out of bounds.Example usage:
countHarnesses
This new function counts the number of matching component instances and returns the result.
Example usage:
Filter by Label
New functionality makes it possible to fetch harnesses for certain form components using their floating label text. Previously, the user would have to either label the component with an id or class, or locate it in a form field using
MatFormFieldHarness.getControl()
.This affects the following harnesses:
Example usage: