build: release script producing duplicate results #30999
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The release script decides which packages to publish by looking for targets with the `release-package` tag, however with the latest infra changes there are actually two targets per package: `npm_package` and `npm_package_files`. This resulted in the release script trying to publish to npm twice which in turn cause an error since versions can't be published over. These changes resolve the issue by: 1. Adjusting the query so it only returns the `npm_package` target. 2. Adding validation that we don't resolve the same package twice.
angular-robot
bot
added
the
area: build & ci
devversion
approved these changes
May 1, 2025
|
The changes were merged into the following branches: main, 19.2.x |
crisbeto
added a commit
that referenced
this pull request
May 1, 2025
The release script decides which packages to publish by looking for targets with the `release-package` tag, however with the latest infra changes there are actually two targets per package: `npm_package` and `npm_package_files`. This resulted in the release script trying to publish to npm twice which in turn cause an error since versions can't be published over. These changes resolve the issue by: 1. Adjusting the query so it only returns the `npm_package` target. 2. Adding validation that we don't resolve the same package twice. (cherry picked from commit 280a233)
wildcardalice
pushed a commit
to wildcardalice/components
that referenced
this pull request
May 12, 2025
The release script decides which packages to publish by looking for targets with the `release-package` tag, however with the latest infra changes there are actually two targets per package: `npm_package` and `npm_package_files`. This resulted in the release script trying to publish to npm twice which in turn cause an error since versions can't be published over. These changes resolve the issue by: 1. Adjusting the query so it only returns the `npm_package` target. 2. Adding validation that we don't resolve the same package twice.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The release script decides which packages to publish by looking for targets with the
release-packagetag, however with the latest infra changes there are actually two targets per package:npm_packageandnpm_package_files. This resulted in the release script trying to publish to npm twice which in turn caused an error since versions can't be published over.These changes resolve the issue by:
npm_packagetarget.