Skip to content

build: remove slack notification config #31228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

crisbeto
Copy link
Member

The job that notifies Slack when a build failed has been broken for a while, likely due to a dependency update and the channel where the updates were being posted only had a handful of team members. These changes remove it since it adds some noise when other failures happen and we're generally good at keeping the CI green.

The job that notifies Slack when a build failed has been broken for a while, likely due to a dependency update and the channel where the updates were being posted only had a handful of team members. These changes remove it since it adds some noise when other failures happen and we're generally good at keeping the CI green.
@crisbeto crisbeto requested review from a team as code owners May 27, 2025 07:13
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label May 27, 2025
@crisbeto crisbeto requested review from andrewseguin, wagnermaciel and devversion and removed request for a team May 27, 2025 07:13
@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label May 27, 2025
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed on removal.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate target: minor This PR is targeted for the next minor release and removed target: patch This PR is targeted for the next patch release target: rc This PR is targeted for the next release-candidate labels May 27, 2025
@crisbeto crisbeto merged commit 6082c1f into angular:main May 27, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants