Skip to content

docs(sidenav): escape pipes in markdown table #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2017

Conversation

GeorgDangl
Copy link
Contributor

replace pipe "|" in markdown tables for correct rendering in a table cell in GitHub

The table in the sidenav readme looks currently like this:
table_error

With the fix, it looks like this:
table_fixed

This seems to be an old but unresolved issue with how GitHub renders MarkDown files / tables.

replace pipe "|" in markdown tables for correct rendering in a table cell in GitHub
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 7, 2017
@devversion devversion requested a review from mmalerba May 8, 2017 15:40
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 8, 2017
Copy link
Contributor

@mmalerba mmalerba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@kara
Copy link
Contributor

kara commented May 9, 2017

Note: We should probably move the info in the table into sidenav.md as well, since the README isn't pushed to the docs site.

@kara kara merged commit 09c8404 into angular:master May 9, 2017
@GeorgDangl GeorgDangl deleted the markdownFix branch May 9, 2017 18:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants