Skip to content

fix(checkbox): set pointer cursor for checkbox #4473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 11, 2017

Conversation

devversion
Copy link
Member

  • Adds the pointer cursor to the whole checkbox layout to also indicate that you can also click on the checkbox container and not only on the label.

Fixes #4185

* Adds the pointer cursor to the whole checkbox layout to also indicate that you can also click on the checkbox container and not only on the label.

Fixes angular#4185
@devversion devversion requested a review from tinayuangao May 11, 2017 05:30
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 11, 2017
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 11, 2017
Copy link
Contributor

@willshowell willshowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the cursor not revert to default when the checkbox is disabled to indicate it is no longer clickable?

@devversion
Copy link
Member Author

@willshowell It does go back to default if the checkbox is disabled.

@willshowell
Copy link
Contributor

Oops - currently the label cursor doesn't revert back to default and I was basing on that. I see how it works now, thanks!

@kara kara merged commit b2f93b5 into angular:master May 11, 2017
@devversion devversion deleted the fix/checkbox-cursor-pointer branch November 11, 2017 10:20
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(checkbox): hover mouse pointer cursor
5 participants