Skip to content

fix(tooltip): don't open from programmatic focus #7258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

crisbeto
Copy link
Member

Prevents the tooltip from opening when its trigger is focused programmatically.

Fixes #7245.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 22, 2017
@crisbeto crisbeto added the Accessibility This issue is related to accessibility (a11y) label Sep 22, 2017
@HitomiTenshi
Copy link

Any chance to get this PR for 2.0.0-beta.13?

I'm stuck with 2.0.0-beta.10 and can't upgrade because of this bug. I'm using a lot of tooltips on icon-buttons which trigger sidenavs or dialogs.

Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin
Copy link
Contributor

Be sure to rebase

Prevents the tooltip from opening when its trigger is focused programmatically.

Fixes angular#7245.
@crisbeto crisbeto force-pushed the 7245/tooltip-focus-origin branch from f0c207f to ea48685 Compare October 6, 2017 16:05
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Oct 6, 2017
@andrewseguin andrewseguin merged commit 90a55fa into angular:master Oct 9, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

matTooltip triggers on focus capture since 2.0.0-beta.11
4 participants