Skip to content

fix(select): theme not being transferred to the panel #7342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2017
Merged

fix(select): theme not being transferred to the panel #7342

merged 1 commit into from
Sep 29, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Sep 26, 2017 •
edited
Loading

  • Fixes the theme from the form field not being transferred to the panel, causing the options to have the wrong color. This seems to have happened during the switch to the form field, but interestingly AoT didn't catch us not having a color anymore (possibly because it's in a binding expression).
  • Moves a test to another test suite since it doesn't belong with the theming tests.

@crisbeto crisbeto added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful pr: needs review labels Sep 26, 2017
@crisbeto crisbeto requested a review from kara as a code owner September 26, 2017 21:06
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 26, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Sep 26, 2017
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround and removed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Sep 26, 2017
@crisbeto
fix(select): theme not being transferred to the panel
25e3686 
* Fixes the theme from the form field not being transferred to the panel, causing the options to have the wrong color. This seems to have happened during the switch to the form field, but interestingly AoT didn't catch us not having a `color` anymore (possible because it's in a binding expression).
* Moves a test to another test suite since it doesn't belong with the theming tests.
@crisbeto crisbeto force-pushed the select-panel-theming branch from edd6e94 to 25e3686 Compare September 29, 2017 16:38
@andrewseguin andrewseguin merged commit 6b70ca6 into angular:master Sep 29, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

@kara kara Awaiting requested review from kara

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @mmalerba @googlebot @andrewseguin