Skip to content

fix(select): active item not being updated on click in multiple mode #7808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

crisbeto
Copy link
Member

Fixes the active option not being updated when the user clicks inside a multi-select, causing it to be stuck on the first option.

@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) pr: needs review labels Oct 15, 2017
@crisbeto crisbeto requested a review from kara as a code owner October 15, 2017 14:19
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 15, 2017
@crisbeto
Copy link
Member Author

@jelbourn could you take a look since it's an accessibility issue?

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

Looks like it has a conflict already

Fixes the active option not being updated when the user clicks inside a multi-select, causing it to be stuck on the first option.
@crisbeto crisbeto force-pushed the select-multiple-active-item branch from c111d92 to 15892ff Compare December 13, 2017 22:49
@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs rebase labels Dec 13, 2017
@jelbourn jelbourn merged commit bc27fea into angular:master Jan 5, 2018
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 8, 2018
…ngular#7808)

Fixes the active option not being updated when the user clicks inside a multi-select, causing it to be stuck on the first option.
jelbourn pushed a commit to jelbourn/components that referenced this pull request Jan 9, 2018
…ngular#7808)

Fixes the active option not being updated when the user clicks inside a multi-select, causing it to be stuck on the first option.
jelbourn pushed a commit that referenced this pull request Jan 9, 2018
…7808)

Fixes the active option not being updated when the user clicks inside a multi-select, causing it to be stuck on the first option.
tinayuangao pushed a commit that referenced this pull request Jan 10, 2018
…7808)

Fixes the active option not being updated when the user clicks inside a multi-select, causing it to be stuck on the first option.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants