Skip to content

fix(chips): Update chips in chip list, and add margin to chip input #8579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2018

Conversation

tinayuangao
Copy link
Contributor

Fixes #8509 #8505

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 21, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Nov 22, 2017
@merobal
Copy link

merobal commented Nov 22, 2017

@tinayuangao Adding stateCheck to ngAfterContentInit not fully solve #8509. In our case we update chips from dialog (where user can select from dozens of filters) and we add the selected filters as chips to the chip input component. Demo for this issue: https://plnkr.co/edit/eGPxQCkLCK7T38GDJOzv?p=preview (add chips via external functionality such as via button click.)

EDIT: sorry, I somehow missed chips.changes there. Looks good and looking forward to be merged.

@tinayuangao
Copy link
Contributor Author

@merobal The stateChange is inside chips.changes so whenever the @ContentChildren(MatChip) chip list changes, stateChange.next() will be triggered.

Tested with your demo and it works.

@merobal
Copy link

merobal commented Dec 6, 2017

@tinayuangao it's still an issue in the final release:
https://youtu.be/-ohHhYxwfD0

@tinayuangao tinayuangao added the target: patch This PR is targeted for the next patch release label Dec 7, 2017
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017
@merobal
Copy link

merobal commented Dec 20, 2017

@tinayuangao do you have any update on this?

@merobal
Copy link

merobal commented Jan 25, 2018

@tinayuangao do you have any progress on this?

@tinayuangao tinayuangao removed the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Mar 1, 2018
@tinayuangao tinayuangao merged commit 67e710c into angular:master Mar 2, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chip input placeholder issue with async chips update
5 participants