-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(chips): Update chips in chip list, and add margin to chip input #8579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@tinayuangao Adding stateCheck to ngAfterContentInit not fully solve #8509. In our case we update chips from dialog (where user can select from dozens of filters) and we add the selected filters as chips to the chip input component. Demo for this issue: https://plnkr.co/edit/eGPxQCkLCK7T38GDJOzv?p=preview (add chips via external functionality such as via button click.) EDIT: sorry, I somehow missed |
@merobal The Tested with your demo and it works. |
e0d21fc
to
8a28164
Compare
@tinayuangao it's still an issue in the final release: |
@tinayuangao do you have any update on this? |
@tinayuangao do you have any progress on this? |
8a28164
to
c38d74e
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes #8509 #8505