Skip to content

fix(form-field): hide required asterisk if control is disabled #8799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 12, 2018
Merged

fix(form-field): hide required asterisk if control is disabled #8799

merged 1 commit into from
Jan 12, 2018

Conversation

devversion
Copy link
Member

  • No longer shows the required asterisk if the form control is disabled.

Fixes #8251.

@devversion devversion requested a review from mmalerba as a code owner December 4, 2017 18:36
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 4, 2017
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels Dec 6, 2017
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Dec 13, 2017
@devversion
fix(form-field): hide required asterisk if control is disabled
afa170e 
* No longer shows the required asterisk if the form control is disabled.

Fixes angular#8251.
@devversion devversion force-pushed the fix/form-field-hide-asterisk-duisabled branch from 44752ae to afa170e Compare December 31, 2017 11:15
@andrewseguin andrewseguin merged commit 1c2f6b7 into angular:master Jan 12, 2018
andrewseguin pushed a commit to andrewseguin/components that referenced this pull request Jan 12, 2018
@devversion @andrewseguin
fix(form-field): hide required asterisk if control is disabled (angul…
2d56386 
…ar#8799)

* No longer shows the required asterisk if the form control is disabled.

Fixes angular#8251.
andrewseguin pushed a commit that referenced this pull request Jan 17, 2018
@devversion @andrewseguin
fix(form-field): hide required asterisk if control is disabled (#8799)
e4e1844 
* No longer shows the required asterisk if the form control is disabled.

Fixes #8251.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mat-form-field required fields should remove the * when disabled
4 participants
@devversion @mmalerba @googlebot @andrewseguin